PERFORCE change 120558 for review

Roman Divacky rdivacky at FreeBSD.org
Wed May 30 14:18:57 UTC 2007


On Tue, May 29, 2007 at 02:45:24PM +0000, Roman Divacky wrote:
> http://perforce.freebsd.org/chv.cgi?CH=120558
> 
> Change 120558 by rdivacky at rdivacky_witten on 2007/05/29 14:44:59
> 
> 	Dont allow zero or negative pid/tid arguments to tgkill/tkill.
> 
> Affected files ...
> 
> .. //depot/projects/soc2007/rdivacky/linux_futex/sys/compat/linux/linux_signal.c#2 edit
> 
> Differences ...
> 
> ==== //depot/projects/soc2007/rdivacky/linux_futex/sys/compat/linux/linux_signal.c#2 (text+ko) ====
> 
> @@ -550,8 +550,8 @@
>  	ka.pid = args->pid;
>  	ka.signum = args->sig;
>  
> -	if (args->tgid == -1)
> -	   	return linux_kill(td, &ka);
> +	if (args->pid <= 0 || args->tgid <= 0)
> +		return EINVAL;

this is a WIP and might be wrapped in if (linux_use26(td)), hard to say ;(


More information about the p4-projects mailing list