PERFORCE change 119527 for review

Garrett Cooper yanegomi at gmail.com
Wed May 9 16:14:57 UTC 2007


Fredrik Lindberg wrote:
> Ivan Voras wrote:
>> On 09/05/07, Fredrik Lindberg <fli at shapeshifter.se> wrote:
>>
>>> Ok, I'll take a look at the various queue.h shipped with the major BSDs,
>>> and see if I can find a common subset that suits my needs (without too
>>> many compromises) and based on the findings I'll reconsider my choice.
>>
>> I use sys/queue.h in my userland applications all the time, there's no
>> problem there.
>>
> 
> And it works on {Net,Open}BSD?, I could swear that I've been bitten by
> sys/queue.h in the past when moving stuff between FreeBSD and NetBSD.
> Could have been those TAILQ-macros Robert Watson talked about though.
> 
> Fredrik Lindberg

It may work with programs under normal conditions but are the queues 
guaranteed to work with thread sychronization and other non-simple 
conditions? I'd think that the FreeBSD queue is closer to that.

Plus the FreeBSD Queue's API is simple and the maintainer doesn't have 
to peruse another set of source looking for the required function / 
method they need.

Furthermore, it's a requirement made by style(9) to use methods that 
aren't rolled by the implementor :).

Just a few thoughts.

-Garrett



More information about the p4-projects mailing list