PERFORCE change 119527 for review

Fredrik Lindberg fli at shapeshifter.se
Wed May 9 10:21:14 UTC 2007


Robert Watson wrote:
> 
> On Wed, 9 May 2007, Fredrik Lindberg wrote:
> 
>> Roman Divacky wrote:
>>> On Tue, May 08, 2007 at 10:29:53PM +0000, Fredrik Lindberg wrote:
>>>> http://perforce.freebsd.org/chv.cgi?CH=119527
>>>>
>>>> Change 119527 by fli at fli_genesis on 2007/05/08 22:29:14
>>>>
>>>>     Add data structures needed by the stack.
>>>>     A Double-linked list and a hash table.
>>>
>>> what about sys/queue.h ? it provides various abstract data types 
>>> including double-linked list
>>
>> Yes, I know it does provide that, and I've used it a lot in the past. 
>> A while ago I needed a linked list for another project where I needed 
>> to be independent of FreeBSD. So I rolled my own (with a similar api) 
>> and I've used it ever since. (It can be used both as a stack and queue).
>>
>> It's not exactly rocket-science and it does increase portability since 
>> this is a userland application. If there aren't any major objections 
>> or other selling points in favor for sys/queue.h (in a userland 
>> application!) I'm just going to leave it as it is.
> 
> FYI, slightly stale versions of queue.h are shipped with both Linux and 
> Mac OS X, so they are actually relatively portable.  Some of the more 
> recent TAILQ macros, etc, aren't available there, so I recently changed 
> from using the OS-native queue.h in OpenBSM to a FreeBSD version I ship 
> to use on those platforms.
> 

Ok, I'll take a look at the various queue.h shipped with the major BSDs,
and see if I can find a common subset that suits my needs (without too
many compromises) and based on the findings I'll reconsider my choice.

Fredrik Lindberg


More information about the p4-projects mailing list