PERFORCE change 119529 for review
Bruce M Simpson
bms at FreeBSD.org
Tue May 8 22:40:54 UTC 2007
http://perforce.freebsd.org/chv.cgi?CH=119529
Change 119529 by bms at bms_anglepoise on 2007/05/08 22:40:28
turn 'busy resource' back into a panic.
trim comments.
Affected files ...
.. //depot/projects/mips2/src/sys/mips/mips/nexus.c#10 edit
Differences ...
==== //depot/projects/mips2/src/sys/mips/mips/nexus.c#10 (text+ko) ====
@@ -199,11 +199,6 @@
nexus_attach(device_t dev)
{
- /*
- * XXX: next line needed to probe clock (intr 5),
- * otherwise no clock and lots of stray hard interrupt 5
- * once compare counts down.
- */
bus_generic_probe(dev);
bus_enumerate_hinted_children(dev);
bus_generic_attach(dev);
@@ -323,9 +318,7 @@
if (rle == NULL)
return (NULL);
if (rle->res != NULL) {
- /* XXX panic? */
- printf("%s: resource entry is busy\n", __func__);
- return (NULL);
+ panic("%s: resource entry is busy", __func__);
}
start = rle->start;
end = rle->end;
@@ -371,7 +364,6 @@
/*
* If this is a memory resource, track the direct mapping
* in the uncached MIPS KSEG1 segment.
- * XXX is this correct?
*/
if (type == SYS_RES_MEMORY) {
void *vaddr;
More information about the p4-projects
mailing list