PERFORCE change 115367 for review
John Baldwin
jhb at freebsd.org
Tue Mar 6 16:00:27 UTC 2007
On Monday 05 March 2007 17:26, John Baldwin wrote:
> On Monday 05 March 2007 16:46, Paolo Pisati wrote:
> > http://perforce.freebsd.org/chv.cgi?CH=115367
> >
> > Change 115367 by piso at piso_newluxor on 2007/03/05 21:45:54
> >
> > o Wrap at 80 ata_pci_setup_intr().
> > o Style(9) a bit the indentation.
>
> You should really preserve the 4-space indent since that's what the rest of
> sys/dev/ata/* uses, and consistency is preserved over a mixed bag.
s/preserved/preferred/
> > Affected files ...
> >
> > .. //depot/projects/soc2006/intr_filter/dev/ata/ata-pci.c#6 edit
> >
> > Differences ...
> >
> > ==== //depot/projects/soc2006/intr_filter/dev/ata/ata-pci.c#6 (text+ko)
====
> >
> > @@ -339,12 +339,12 @@
> >
> > int
> > ata_pci_setup_intr(device_t dev, device_t child, struct resource *irq,
> > - int flags, driver_filter_t *filter, driver_intr_t *function,
> > - void *argument, void **cookiep)
> > + int flags, driver_filter_t *filter, driver_intr_t *function,
> > + void *argument, void **cookiep)
> > {
> > if (ata_legacy(dev)) {
> > - return BUS_SETUP_INTR(device_get_parent(dev), child, irq,
> > - flags, filter, function, argument, cookiep);
> > + return BUS_SETUP_INTR(device_get_parent(dev), child, irq,
> > + flags, filter, function, argument, cookiep);
> > }
> > else {
> > struct ata_pci_controller *controller = device_get_softc(dev);
> >
>
> --
> John Baldwin
>
--
John Baldwin
More information about the p4-projects
mailing list