PERFORCE change 124344 for review
Ulf Lilleengen
lulf at FreeBSD.org
Tue Jul 31 20:00:17 UTC 2007
On Tue, Jul 31, 2007 at 07:51:05PM +0200, Pawel Jakub Dawidek wrote:
> On Mon, Jul 30, 2007 at 10:47:13AM +0000, Ulf Lilleengen wrote:
> > http://perforce.freebsd.org/chv.cgi?CH=124344
> >
> > Change 124344 by lulf at lulf_carrot on 2007/07/30 10:47:07
> >
> > - Sleep after sending create requests in userland, since the event might
> > not yet be processed. If there are noteable issues with this, which is
> > a quite unlikely to happen, I have a patch to support suspending
> > of the userland process until the events are executed, but it's only
> > required in this special case.
>
> Sleeping that way is, as you noted, not very nice... Can't you put a
> loop below errstr check, which will wait for drive creation. You could
> sleep for eg. 0.1s between checks. Also not very nice, but even 2s may
> be too low on very loaded systems.
Hmm, yes I agree. Just committed a fix that does this. I'm more and more
considering the suspending patch :)
Anyway.. thanks.
--
Ulf Lilleengen
More information about the p4-projects
mailing list