PERFORCE change 124299 for review

Peter Wemm peter at FreeBSD.org
Sun Jul 29 06:38:44 UTC 2007


http://perforce.freebsd.org/chv.cgi?CH=124299

Change 124299 by peter at peter_overcee on 2007/07/29 06:38:33

	Increase timeout from 1/1000th of a second to 1/4 second.  1 tick was
	almost fine at 100hz, but is way too short at 1000hz.  1/4 second is far
	more reasonable since it is a catastrophic failure of the card (firmware
	crashed or something).
	
	If the timeout fires, it actually causes the driver to break.  So an
	accidental misfire is a Bad Thing(TM).

Affected files ...

.. //depot/projects/hammer/sys/dev/si/si.c#23 edit

Differences ...

==== //depot/projects/hammer/sys/dev/si/si.c#23 (text+ko) ====

@@ -1547,7 +1547,9 @@
 			x != IDLE_BREAK &&
 			x != cmd) {
 		if (ttysleep(pp->sp_tty, (caddr_t)&pp->sp_state, TTIPRI|PCATCH,
-				"sicmd1", 1)) {
+				"sicmd1", hz/4)) {
+			/* This is very very bad.  The card has crashed. */
+			/* XXX the driver breaks at this point */
 			splx(oldspl);
 			return;
 		}


More information about the p4-projects mailing list