PERFORCE change 123870 for review

Peter Wemm peter at FreeBSD.org
Sat Jul 21 22:39:43 UTC 2007


http://perforce.freebsd.org/chv.cgi?CH=123870

Change 123870 by peter at peter_overcee on 2007/07/21 22:39:35

	Fix startup order bug that causes local apic startup to happen
	in an indeterminate order relative to cpu_startup/printcpuinfo.
	If it happens before printcpuinfo, then the CPUID_HTT turnoff
	won't have happened yet, and it can put both physical cores into
	a htt group.  This is kind of a bandaid.

Affected files ...

.. //depot/projects/hammer/sys/amd64/amd64/local_apic.c#73 edit
.. //depot/projects/hammer/sys/i386/i386/local_apic.c#30 edit

Differences ...

==== //depot/projects/hammer/sys/amd64/amd64/local_apic.c#73 (text+ko) ====

@@ -1065,7 +1065,7 @@
 	mp_topology();
 #endif
 }
-SYSINIT(apic_setup_local, SI_SUB_CPU, SI_ORDER_FIRST, apic_setup_local, NULL)
+SYSINIT(apic_setup_local, SI_SUB_CPU, SI_ORDER_SECOND, apic_setup_local, NULL)
 
 /*
  * Setup the I/O APICs.

==== //depot/projects/hammer/sys/i386/i386/local_apic.c#30 (text+ko) ====

@@ -1069,7 +1069,7 @@
 	mp_topology();
 #endif
 }
-SYSINIT(apic_init, SI_SUB_CPU, SI_ORDER_FIRST, apic_init, NULL)
+SYSINIT(apic_init, SI_SUB_CPU, SI_ORDER_SECOND, apic_init, NULL)
 
 /*
  * Setup the I/O APICs.


More information about the p4-projects mailing list