PERFORCE change 122829 for review

Attilio Rao attilio at freebsd.org
Wed Jul 4 15:15:14 UTC 2007


2007/7/4, Rui Paulo <rpaulo at freebsd.org>:
>  struct asmc_softc {
> -       device_t        sc_dev;
> -       struct mtx      sc_mtx;
> -
> -       int             sc_nfan;
> -
> -       int16_t         sms_rest_x;
> -       int16_t         sms_rest_y;
> -       int16_t         sms_rest_z;
> -
> +       device_t                sc_dev;
> +       struct mtx              sc_mtx;
> +       int                     sc_nfan;
> +       int16_t                 sms_rest_x;
> +       int16_t                 sms_rest_y;
> +       int16_t                 sms_rest_z;
>        struct sysctl_ctx_list  sc_sysctl_ctx;
> -       struct sysctl_oid      *sc_root_tree;
> -       struct sysctl_oid      *sc_fan_tree[ASMC_MAXFANS+1];
> -       struct sysctl_oid      *sc_temp_tree;
> -       struct sysctl_oid      *sc_sms_tree;
> -
> -       struct asmc_model       *sc_model;
> -
> -       int                     sc_rid;
> -       struct resource         *sc_res;
> -       void                    *sc_cookie;
> -
> -       int                     sms_intrtype;
> -       struct taskqueue        *sms_tq;
> -       struct task             sms_task;
> +       struct sysctl_oid       *sc_root_tree;
> +       struct sysctl_oid       *sc_fan_tree[ASMC_MAXFANS+1];
> +       struct sysctl_oid       *sc_temp_tree;
> +       struct sysctl_oid       *sc_sms_tree;
> +       struct asmc_model       *sc_model;
> +       int                     sc_rid;
> +       struct resource         *sc_res;
> +       void                    *sc_cookie;
> +       int                     sms_intrtype;
> +       struct taskqueue        *sms_tq;
> +       struct task             sms_task;
>  };

Members of the same struct should have the same name prefix, in this
case you should not mix between sc_ and sms_.

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein


More information about the p4-projects mailing list