PERFORCE change 113740 for review

Robert Watson rwatson at FreeBSD.org
Wed Jan 31 00:48:20 UTC 2007


http://perforce.freebsd.org/chv.cgi?CH=113740

Change 113740 by rwatson at rwatson_peppercorn on 2007/01/31 00:47:31

	Don't document the order the pointers are returned in by getzbuf.

Affected files ...

.. //depot/projects/zcopybpf/src/sys/net/bpf_zerocopy.c#5 edit

Differences ...

==== //depot/projects/zcopybpf/src/sys/net/bpf_zerocopy.c#5 (text+ko) ====

@@ -421,7 +421,8 @@
  * copied versions of those originally submitted via the setzbuf ioctl--if
  * user space has remapped the buffers, then they may be inconsistent.  User
  * applications must be aware that these are in effect buffer names, not
- * pointers, if they play such games with their address space.
+ * pointers, if they play such games with their address space.  Pointers are
+ * returned in arbitrary order, which may vary by ioctl.
  */
 int
 bpf_zerocopy_ioctl_getzbuf(struct thread *td, struct bpf_d *d,
@@ -432,9 +433,6 @@
 	KASSERT(d->bd_bufmode == BPF_BUFMODE_ZBUF,
 	    ("bpf_zerocopy_ioctl_getzbuf: not in zbuf mode"));
 
-	/*
-	 * Sort so that the next buffer to read is the 'a' buffer.
-	 */
 	bzero(bz, sizeof(*bz));
 	BPFD_LOCK(d);
 	if (d->bd_hbuf != NULL) {


More information about the p4-projects mailing list