[Fwd: PERFORCE change 106715 for review]

[Attilio Rao]

2006/9/26, Sam Leffler <sam at errno.com>:
> >
> >
> > -------- Original Message --------
> > Subject: PERFORCE change 106715 for review
> > Date: Tue, 26 Sep 2006 12:24:36 GMT
> > From: Attilio Rao <attilio at freebsd.org>
> > To: Perforce Change Reviews <perforce at freebsd.org>
> >
> > http://perforce.freebsd.org/chv.cgi?CH=106715
> >
> > Change 106715 by attilio at attilio_laptop on 2006/09/26 12:24:02
> >
> >       It applies style(9) for header. This is a starting point for a complete
> >       style(9)-ization of USB new stack.
> >
>
> Can someone please fill me in on what's going on?  I've been heckling
> Hans about making gratuitous changes to the "new usb stack" before it
> goes into cvs and now Attilio comes along and smacks the code.  Are
> folks sufficiently comfortable with the code that they don't care about
> being able to track work on other BSD systems and/or compare the code
> against what is currently in CVS? (which was the point of my original
> complaints).
>
> I will happily shut up if this has all been hammered out...

Well, first of all, maybe you would cc other people (me, tom@ and
imp@) that are currently working on this branch about your ideas on
USB changes (since in the way you did I'm completely obscure of
discussions between you and hans about this...).
Than, it is unclear how USB stack might (and please I would point out
the word 'might') be included into the kernel. Since the new stack is
reasonably different from the previous I assume it might be replaced
totally after a good testing period respect a gradual inclusion.
In this view, since Hans' code completely miss style(9), I was only
stylizing the code.
If there is something unclear please mail me.

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein