PERFORCE change 106251 for review

Tom Rhodes trhodes at FreeBSD.org
Sun Sep 17 10:31:38 PDT 2006


http://perforce.freebsd.org/chv.cgi?CH=106251

Change 106251 by trhodes at trhodes_local on 2006/09/17 17:31:03

	Remove code block for allocating a dma tag for transfer buffers.
	This is now handled by usb_subr.c's usbd_dma_tag_alloc()
	function.

Affected files ...

.. //depot/projects/usb/src/sys/dev/usb/uhci_pci.c#8 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/usb/uhci_pci.c#8 (text+ko) ====

@@ -309,29 +309,6 @@
 #endif
 	pci_write_config(self, PCI_LEGSUP, PCI_LEGSUP_USBPIRQDEN, 2);
 
-	/* Allocate a parent dma tag for DMA maps */
-	err = bus_dma_tag_create(NULL, 1, 0, BUS_SPACE_MAXADDR_32BIT,
-	    BUS_SPACE_MAXADDR, NULL, NULL, BUS_SPACE_MAXSIZE_32BIT,
-	    USB_DMA_NSEG, BUS_SPACE_MAXSIZE_32BIT, 0, NULL, NULL,
-	    &sc->sc_bus.parent_dmatag);
-	if (err) {
-		device_printf(self, "Could not allocate parent DMA tag (%d)\n",
-		    err);
-		uhci_pci_detach(self);
-		return ENXIO;
-	}
-	/* Allocate a dma tag for transfer buffers */
-	err = bus_dma_tag_create(sc->sc_bus.parent_dmatag, 1, 0,
-	    BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR, NULL, NULL,
-	    BUS_SPACE_MAXSIZE_32BIT, USB_DMA_NSEG, BUS_SPACE_MAXSIZE_32BIT, 0,
-	    busdma_lock_mutex, &Giant, &sc->sc_bus.buffer_dmatag);
-	if (err) {
-		device_printf(self, "Could not allocate transfer tag (%d)\n",
-		    err);
-		uhci_pci_detach(self);
-		return ENXIO;
-	}
-
 	err = uhci_init(sc);
 	if(!err)
 	{


More information about the p4-projects mailing list