PERFORCE change 107380 for review

Warner Losh imp at FreeBSD.org
Fri Oct 6 16:26:04 PDT 2006


http://perforce.freebsd.org/chv.cgi?CH=107380

Change 107380 by imp at imp_lighthouse on 2006/10/06 23:25:23

	Fix logic error.  Also cleanup a little on error.

Affected files ...

.. //depot/projects/arm/src/sys/dev/spibus/spibus.c#5 edit

Differences ...

==== //depot/projects/arm/src/sys/dev/spibus/spibus.c#5 (text+ko) ====

@@ -136,8 +136,10 @@
 	if (child == NULL) 
 		return (child);
 	devi = malloc(sizeof(struct spibus_ivar), M_DEVBUF, M_NOWAIT | M_ZERO);
-	if (devi != NULL)
+	if (devi == NULL) {
+		device_delete_child(dev, child);
 		return (0);
+	}
 	device_set_ivars(child, devi);
 	return (child);
 }


More information about the p4-projects mailing list