PERFORCE change 99144 for review
Divacky Roman
xdivac02 at stud.fit.vutbr.cz
Fri Jun 16 16:22:25 UTC 2006
On Thu, Jun 15, 2006 at 02:35:04PM -0400, John Baldwin wrote:
> On Thursday 15 June 2006 04:19, Divacky Roman wrote:
> > On Tue, Jun 13, 2006 at 01:44:08PM -0400, John Baldwin wrote:
> > > On Tuesday 13 June 2006 13:12, Roman Divacky wrote:
> > > > http://perforce.freebsd.org/chv.cgi?CH=99144
> > > >
> > > > Change 99144 by rdivacky at rdivacky_witten on 2006/06/13 17:12:02
> > > >
> > > > Make the LINUXBASE path settable via sysctl. Useful when you have more
> then
> > > one linux bases
> > > > installed etc.
> > >
> > > Since you only check the one global variable, why did you make the
> sysctl's
> > > try to handle per-prison paths?
> >
> > well... none of the per-prison variables is checkd against anywhere so I
> > thought there's some magic behind and just copied the code from the other
> > variables.
> >
> > can you explain me how this works? to me it seems either like unfinished
> work
> > or nonsense :)
>
> All the other per-prison variables are accessed via the linux_get_foo()
> functions (like uname, etc.) and those functions look in the prison. However,
> you are passing linux_emul_path directly to calls to kern_alternate_path()
> (see the CHECKALT macros). You would have to change those macros to instead
> call a linux_get_path() function that looked in the prison if you wanted
> different prisons to have their own compat paths.
the emul_path is used in just 3 places, 2 are in linprocfs and 1 in linuxolator
I'll commit update to it, pls review it then
More information about the p4-projects
mailing list