PERFORCE change 101845 for review

John Baldwin jhb at freebsd.org
Tue Jul 18 19:22:34 UTC 2006


On Tuesday 18 July 2006 07:07, Paolo Pisati wrote:
> http://perforce.freebsd.org/chv.cgi?CH=101845
> 
> Change 101845 by piso at piso_newluxor on 2006/07/18 11:07:29
> 
> 	Defining an interrupt handler as INTR_FAST means 
> 	the interrupt thread associated to this interrupt event
> 	won't be created: actually with filter+ithread, we need
> 	that thread.

The real fix is to stop checking INTR_FAST and to create an ithread as long as 
at least one interrupt handler (struct intr_handler) has a threaded handler 
(ih_handler != NULL).

> Affected files ...
> 
> .. //depot/projects/soc2006/intr_filter/dev/em/if_em.c#7 edit
> 
> Differences ...
> 
> ==== //depot/projects/soc2006/intr_filter/dev/em/if_em.c#7 (text+ko) ====
> 
> @@ -1986,7 +1986,7 @@
>  	 */
>  	TASK_INIT(&sc->link_task, 0, em_handle_link, sc);
>  	if ((error = bus_setup_intr(dev, sc->res_interrupt,
> -	    INTR_TYPE_NET | INTR_FAST, em_intr_fast, em_handle_rxtx, sc,
> +	    INTR_TYPE_NET, em_intr_fast, em_handle_rxtx, sc,
>  	    &sc->int_handler_tag)) != 0) {
>  		device_printf(dev, "Failed to register fast interrupt "
>  			    "handler: %d\n", error);
> 

-- 
John Baldwin


More information about the p4-projects mailing list