PERFORCE change 100859 for review

Wojciech A. Koszek wkoszek at FreeBSD.org
Fri Jul 7 10:59:22 UTC 2006


http://perforce.freebsd.org/chv.cgi?CH=100859

Change 100859 by wkoszek at wkoszek_laptop on 2006/07/07 10:58:41

	Atomic operations here are like: block interrupts -> do operation ->
	unblock interrupts. Thus, I think double intr_disable() here is a
	mistake. Replace it with intr_restore().

Affected files ...

.. //depot/projects/mips2/src/sys/mips/include/atomic.h#3 edit

Differences ...

==== //depot/projects/mips2/src/sys/mips/include/atomic.h#3 (text+ko) ====

@@ -133,7 +133,14 @@
 	s = intr_disable();
 	result = *addr;
 	*addr = 0;
+	/*
+	 * XXXMIPS: I think it's a mistake. We should have intr_restore()
+	 * here, shouldn't we?
+	 */
+#if 0
 	intr_disable();
+#endif
+	intr_restore(s);
 	return (result);
 }
 


More information about the p4-projects mailing list