PERFORCE change 100719 for review
Divacky Roman
xdivac02 at stud.fit.vutbr.cz
Thu Jul 6 12:02:08 UTC 2006
> > + /* we have to call linux exit hook */
> > + if (p->p_flag & P_LINUX && linux_proc_exit_p != NULL)
> > + (linux_proc_exit_p)(td);
> > MALLOC(p->p_ru, struct rusage *, sizeof(struct rusage),
> > M_ZOMBIE, M_WAITOK);
> > /*
> >
>
> Please use a 'process_exit' eventhandler instead. You can test P_LINUX in
> your handler and return right away for non-Linux procs.
oh.. didnt notice.. thnx for telling me
> > + /* linux userret */
> > + if (p->p_flag & P_LINUX && linux_userret_p != NULL)
> > + (linux_userret_p)(td);
> > +
> > /*
> > * Let the scheduler adjust our priority etc.
> > */
> >
>
> If it is needed we can add a new 'thread_userret' eventhandler rather than
> putting Linux-specific hooks into the code.
sounds ok
> > ==== //depot/projects/soc2006/rdivacky_linuxolator/sys/proc.h#2 (text+ko) ====
> >
> > @@ -655,6 +655,7 @@
> > #define P_HWPMC 0x800000 /* Process is using HWPMCs */
> >
> > #define P_JAILED 0x1000000 /* Process is in jail. */
> > +#define P_LINUX 0x2000000 /* linux binary */
> > #define P_INEXEC 0x4000000 /* Process is in execve(). */
> > #define P_STATCHILD 0x8000000 /* Child process stopped or exited. */
>
> If you do the two above, then you might be able to come up with another test
> (compare p_sysvec?) instead of needing this flag since the only tests of it
> would be in the emulator code itself.
yes.. it does not seem necessary now. what is p_sysvec?
anyway - the code I commited has many issues I hope to fix soon (in hours) take
this as WIP.
More information about the p4-projects
mailing list