PERFORCE change 91721 for review

Marcel Moolenaar marcel at FreeBSD.org
Mon Feb 13 19:35:44 PST 2006


http://perforce.freebsd.org/chv.cgi?CH=91721

Change 91721 by marcel at marcel_nfs on 2006/02/14 03:34:53

	o  Don't set the newly allocated resource's start and end,
	   because those are rman internals and implement the rman
	   without needing them.
	o  Fix a misleading comment.

Affected files ...

.. //depot/projects/uart/dev/scc/scc_core.c#7 edit

Differences ...

==== //depot/projects/uart/dev/scc/scc_core.c#7 (text+ko) ====

@@ -181,8 +181,6 @@
 		    sc->sc_rrid);
 		rle->res = malloc(sizeof(struct resource), M_SCC,
 		    M_WAITOK | M_ZERO);
-		rman_set_start(rle->res, rle->start);
-		rman_set_end(rle->res, rle->end);
 		bus_space_subregion(rman_get_bustag(sc->sc_rres),
 		    rman_get_bushandle(sc->sc_rres),
 		    start - rman_get_start(sc->sc_rres), size, &bh);
@@ -257,8 +255,7 @@
 	 * Allocate the register resource. We assume that all SCCs have a
 	 * single register window in either I/O port space or memory mapped
 	 * I/O space. Any SCC that needs multiple windows will consequently
-	 * not be supported by this driver as-is. We try I/O port space
-	 * first to satisfy the EBus code.
+	 * not be supported by this driver as-is.
 	 */
 	sc->sc_rrid = 0;
 	sc->sc_rtype = SYS_RES_MEMORY;


More information about the p4-projects mailing list