PERFORCE change 90962 for review

[Warner Losh]

http://perforce.freebsd.org/chv.cgi?CH=90962

Change 90962 by imp at imp_Speedy on 2006/02/03 07:50:03

	Nits, mostly comments.

Affected files ...

.. //depot/projects/arm/src/sys/arm/at91/if_ate.c#23 edit

Differences ...

==== //depot/projects/arm/src/sys/arm/at91/if_ate.c#23 (text+ko) ====

@@ -22,6 +22,18 @@
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+/* TODO: (in no order)
+ *
+ * 1) detach
+ * 2) Free dma setup
+ * 3) Turn on the clock in pmc and turn on pins?  Turn off?
+ * 4) Setup multicast filters
+ * 5) Setup RX buffers in ateinit_locked
+ * 6) Interrupt bits as appropriate
+ * 7) Keep track of the mbufs in flight on TX and free them in the ISR.
+ * 8) Need to sync busdma goo in atestop
+ */
+
 #include <sys/cdefs.h>
 __FBSDID("$FreeBSD$");
 
@@ -85,10 +97,6 @@
 	struct mbuf *rx_mbuf[ATE_MAX_RX_BUFFERS]; /* RX mbufs */
 	bus_addr_t rx_desc_phys;
 	eth_rx_desc_t *rx_descs;
-
-	// XXX bogus
-	int intr;
-
 	struct	ifmib_iso_8802_3 mibdata; /* stuff for network mgmt */
 };
 
@@ -517,7 +525,6 @@
 	int status;
 	int i;
 		
-	sc->intr++;
 	status = RD4(sc, ETH_ISR);
 	if (status == 0)
 		return;