PERFORCE change 90830 for review

[Peter Pentchev]

On Thu, Feb 02, 2006 at 10:24:04PM +0100, Pawel Worach wrote:
> John Baldwin wrote:
> >
> >Actually, I think && is right.  The conditional code is meant to be 
> >exposed to userland and not the kernel and _KERNEL is for FreeBSD and 
> >KERNEL for OS X.
> >
> 
> Aha, in that case the #endif comment needs updating :)
> 
> --- sys/bsm/audit.h.orig	Thu Feb  2 21:40:33 2006
> +++ sys/bsm/audit.h	Thu Feb  2 21:40:44 2006
> @@ -338,7 +338,7 @@
>  int	setaudit(const struct auditinfo *);
>  int	getaudit_addr(struct auditinfo_addr *, int);
>  int	setaudit_addr(const struct auditinfo_addr *, int);
> -#endif /* defined(_KERNEL) || defined(KERNEL) */
> +#endif /* defined(_KERNEL) && defined(KERNEL) */

It seems that it ought indeed to be changed, but *with* the '!'s before
the conditions - a && b and !a && !b are two completely different things,
y'know :)  !a && !b and a || b are related, true, but style(9) seems
to say that it should indeed be !a && !b in this case.

G'luck,
Peter

-- 
Peter Pentchev	roam at ringlet.net    roam at cnsys.bg    roam at FreeBSD.org
PGP key:	http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint	FDBA FD79 C26F 3C51 C95E  DF9E ED18 B68D 1619 4553
If this sentence didn't exist, somebody would have invented it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/p4-projects/attachments/20060202/cd64d939/attachment.bin