PERFORCE change 103937 for review

[John Birrell]

http://perforce.freebsd.org/chv.cgi?CH=103937

Change 103937 by jb at jb_freebsd2 on 2006/08/15 02:02:10

	Jack the compile warning level up to encourage people to write
	clean code.
	
	It would be nice if the OpenSolaris people would stop wearing the
	"we compile our tree with gcc" as a badge of honour because that
	means very little if you don't use even the most basic gcc warning
	levels.
	
	I was once shouted down by a gcc developer for asking that code
	compile cleanly. He said: "we'll never let a compiler tell us
	how to write code".
	
	I disagree. If the warnings make sense, then they should be used.
	All all the 'const' override casts in OpenSolaris code fall into
	that category. If a developer goes to the trouble of declaring
	something 'const', then it's supposed to be _CONSTANT_ and that
	doesn't give you the right to override that.
	
	[ Little rant there. 8-) ]

Affected files ...

.. //depot/projects/dtrace/src/cddl/Makefile.inc#4 edit

Differences ...

==== //depot/projects/dtrace/src/cddl/Makefile.inc#4 (text+ko) ====

@@ -7,3 +7,5 @@
 CFLAGS+=	-D_SOLARIS_C_SOURCE
 
 IGNORE_PRAGMA=	1
+
+WARNS?=		6