PERFORCE change 81693 for review
Robert Watson
rwatson at FreeBSD.org
Mon Aug 8 23:50:34 GMT 2005
http://perforce.freebsd.org/chv.cgi?CH=81693
Change 81693 by rwatson at rwatson_peppercorn on 2005/08/08 23:49:40
De-comment or de-XXX a few places for merge to CVS.
Affected files ...
.. //depot/projects/netsmp/src/sys/net/if_var.h#10 edit
.. //depot/projects/netsmp/src/sys/net/if_vlan.c#5 edit
Differences ...
==== //depot/projects/netsmp/src/sys/net/if_var.h#10 (text+ko) ====
@@ -423,8 +423,8 @@
#define IFQ_SET_MAXLEN(ifq, len) ((ifq)->ifq_maxlen = (len))
/*
- * XXXRW: The IFF_DRV_OACTIVE test should really occur in the device driver,
- * not in the handoff logic, as that flag is locked by the device driver.
+ * The IFF_DRV_OACTIVE test should really occur in the device driver, not in
+ * the handoff logic, as that flag is locked by the device driver.
*/
#define IFQ_HANDOFF_ADJ(ifp, m, adj, err) \
do { \
==== //depot/projects/netsmp/src/sys/net/if_vlan.c#5 (text+ko) ====
@@ -188,15 +188,6 @@
}
/* Now program new ones. */
-
- /*
- * XXXRW: Really, this should happen in two steps, interlocked by the
- * vlan mutex (if any: first, the parent interface's address list
- * should be propagated to the softc, then from the softc to the
- * child, in order to avoid holding parent's and child's if_addr_mtx
- * at the same time. Races can occur, but won't result in
- * incorrectness. Assuming there is a vlan mutex.
- */
IF_ADDR_LOCK(ifp);
TAILQ_FOREACH(ifma, &ifp->if_multiaddrs, ifma_link) {
if (ifma->ifma_addr->sa_family != AF_LINK)
More information about the p4-projects
mailing list