PERFORCE change 55123 for review

Marcel Moolenaar marcel at FreeBSD.org
Thu Jun 17 01:24:15 GMT 2004


http://perforce.freebsd.org/chv.cgi?CH=55123

Change 55123 by marcel at marcel_nfs on 2004/06/17 01:23:21

	o  The psaddr_t type is supposed to be defined in <sys/procfs.h>.
	   Move it there.
	o  Properly declare struct ps_prochandle as an opaque structure.
	   The implemention is defined by the provider of the service,
	   not in this header.
	o  Fix the prototype of ps_plog().

Affected files ...

.. //depot/projects/gdb/include/proc_service.h#2 edit
.. //depot/projects/gdb/sys/sys/procfs.h#3 edit

Differences ...

==== //depot/projects/gdb/include/proc_service.h#2 (text+ko) ====

@@ -42,11 +42,8 @@
 	PS_NOSYM		/* Symbol not found. */
 } ps_err_e;
 
-struct ps_prochandle {
-};
+struct ps_prochandle;		/* Opaque type. Defined by the implementor. */
 
-typedef void *psaddr_t;		/* An address in the target process. */
-
 __BEGIN_DECLS
 ps_err_e ps_lcontinue(struct ps_prochandle *, lwpid_t);
 ps_err_e ps_lgetfpregs(struct ps_prochandle *, lwpid_t, prfpregset_t *);
@@ -60,7 +57,7 @@
 ps_err_e ps_pdwrite(struct ps_prochandle *, psaddr_t, const void *, size_t);
 ps_err_e ps_pglobal_lookup(struct ps_prochandle *, const char *, const char *,
     psaddr_t *);
-void	 ps_plog(const char *);
+void	 ps_plog(const char *, ...);
 ps_err_e ps_pstop(struct ps_prochandle *);
 ps_err_e ps_ptread(struct ps_prochandle *, psaddr_t, void *, size_t);
 ps_err_e ps_ptwrite(struct ps_prochandle *, psaddr_t, const void *, size_t);

==== //depot/projects/gdb/sys/sys/procfs.h#3 (text+ko) ====

@@ -80,4 +80,6 @@
     char	pr_psargs[PRARGSZ+1];	/* Arguments, null terminated (1) */
 } prpsinfo_t;
 
+typedef void *psaddr_t;		/* An address in the target process. */
+
 #endif /* _SYS_PROCFS_H_ */


More information about the p4-projects mailing list