PERFORCE change 54703 for review

Marcel Moolenaar marcel at FreeBSD.org
Sat Jun 12 06:51:50 GMT 2004


http://perforce.freebsd.org/chv.cgi?CH=54703

Change 54703 by marcel at marcel_nfs on 2004/06/12 06:51:41

	In gdb_tx_mem, use pointers to unsigned char to avoid
	sign-extension. That breaks the construction of packets.

Affected files ...

.. //depot/projects/gdb/usr.bin/kgdb/packet.c#4 edit

Differences ...

==== //depot/projects/gdb/usr.bin/kgdb/packet.c#4 (text+ko) ====

@@ -310,8 +310,8 @@
 int
 gdb_tx_mem(const unsigned char *addr, size_t size)
 {
-	char sbuf[256];
-	char *dbuf, *p;
+	unsigned char sbuf[256];
+	unsigned char *dbuf, *p;
 	ssize_t res;
 
 	dbuf = (size > sizeof(sbuf)) ? malloc(size) : sbuf;


More information about the p4-projects mailing list