PERFORCE change 58484 for review

Julian Elischer julian at elischer.org
Thu Jul 29 13:38:09 PDT 2004



John Baldwin wrote:

>http://perforce.freebsd.org/chv.cgi?CH=58484
>
>Change 58484 by jhb at jhb_slimer on 2004/07/29 20:35:13
>
>	Try to optimize intr_disable/restore by avoiding cli/sti like the
>	plague.
>

shouldn't one of these tests be reversed?

>
>Affected files ...
>
>.. //depot/projects/smpng/sys/i386/include/cpufunc.h#28 edit
>
>Differences ...
>
>==== //depot/projects/smpng/sys/i386/include/cpufunc.h#28 (text+ko) ====
>
>@@ -611,14 +611,16 @@
> 	register_t eflags;
> 
> 	eflags = read_eflags();
>-	disable_intr();
>+	if (eflags & PSL_I)
>+		disable_intr();
> 	return (eflags);
> }
> 
> static __inline void
> intr_restore(register_t eflags)
> {
>-	write_eflags(eflags);
>+	if (eflags & PSL_I)
>+		enable_intr();
> }
> 
> #else /* !(__GNUC__ || __INTEL_COMPILER) */
>  
>



More information about the p4-projects mailing list