PERFORCE change 41566 for review
Sam Leffler
sam at errno.com
Thu Nov 6 10:30:46 PST 2003
On Thursday 06 November 2003 12:26 am, M. Warner Losh wrote:
> In message: <200311060513.hA65Da5J091575 at repoman.freebsd.org>
>
> Sam Leffler <sam at freebsd.org> writes:
> : diff reduction against head
> : - SIS_UNLOCK(sc);
> : (*ifp->if_input)(ifp, m);
> : - SIS_LOCK(sc);
>
> does this mean that we can call if_input with our locks held?
sis's lock is setup MTX_RECURSE in which case re-entry is handled. You only
need to release the lock when you may be re-entered and it's not setup as
recursive. I think recursive locks are bad but so long as the driver is
setup to use them I'm not releasing them when calling up.
Sam
More information about the p4-projects
mailing list