Leftover code in gnttab.h?

[Pratyush Yadav]

Hi everyone,

I was reading the Xen grant table code and I noticed that some code is
wrapped in an #if 0. You can see it in sys/xen/gnttab.h:138. I have
also attached the "commented out" part down below.

Is it useful? Is it all right if I submit a patch that removes it?

Regards,
Pratyush Yadav



#if 0

#include <xen/features.h>

static inline void
gnttab_set_map_op(struct gnttab_map_grant_ref *map, vm_paddr_t addr,
  uint32_t flags, grant_ref_t ref, domid_t domid)
{
if (flags & GNTMAP_contains_pte)
map->host_addr = addr;
else
map->host_addr = vtophys(addr);

map->flags = flags;
map->ref = ref;
map->dom = domid;
}

static inline void
gnttab_set_unmap_op(struct gnttab_unmap_grant_ref *unmap, vm_paddr_t addr,
    uint32_t flags, grant_handle_t handle)
{
if (flags & GNTMAP_contains_pte)
unmap->host_addr = addr;
else
unmap->host_addr = vtophys(addr);

unmap->handle = handle;
unmap->dev_bus_addr = 0;
}

static inline void
gnttab_set_replace_op(struct gnttab_unmap_and_replace *unmap, vm_paddr_t addr,
      vm_paddr_t new_addr, grant_handle_t handle)
{
unmap->host_addr = vtophys(addr);
unmap->new_addr = vtophys(new_addr);

unmap->handle = handle;
}
#endif