svn commit: r310177 - in head/sys: amd64/conf i386/conf

[Colin Percival]

This commit breaks the Xen boot:
> panic: NULL pcpu device_t

> cpuid = 0

> KDB: stack backtrace:

> db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xffffffff82233a20

> vpanic() at vpanic+0x186/frame 0xffffffff82233aa0

> kassert_panic() at kassert_panic+0x126/frame 0xffffffff82233b10

> xen_setup_cpus() at xen_setup_cpus+0x5b/frame 0xffffffff82233b50

> mi_startup() at mi_startup+0x118/frame 0xffffffff82233b70

> btext() at btext+0x2c


I'm assuming this means xenpvcpu_attach isn't running early enough; does
anyone have time to track this down and fix it?

On 12/16/16 13:10, John Baldwin wrote:
> Author: jhb
> Date: Fri Dec 16 21:10:37 2016
> New Revision: 310177
> URL: https://svnweb.freebsd.org/changeset/base/310177
> 
> Log:
>   Enable EARLY_AP_STARTUP on amd64 and i386 kernels by default.
>   
>   PR:		199321, 203682
>   MFC after:	2 months
>   Sponsored by:	Netflix
> 
> Modified:
>   head/sys/amd64/conf/GENERIC
>   head/sys/amd64/conf/MINIMAL
>   head/sys/i386/conf/GENERIC
> 
> Modified: head/sys/amd64/conf/GENERIC
> ==============================================================================
> --- head/sys/amd64/conf/GENERIC	Fri Dec 16 20:49:50 2016	(r310176)
> +++ head/sys/amd64/conf/GENERIC	Fri Dec 16 21:10:37 2016	(r310177)
> @@ -98,6 +98,7 @@ options 	MALLOC_DEBUG_MAXZONES=8	# Separ
>  # Make an SMP-capable kernel by default
>  options 	SMP			# Symmetric MultiProcessor Kernel
>  options 	DEVICE_NUMA		# I/O Device Affinity
> +options 	EARLY_AP_STARTUP
>  
>  # CPU frequency control
>  device		cpufreq
> 
> Modified: head/sys/amd64/conf/MINIMAL
> ==============================================================================
> --- head/sys/amd64/conf/MINIMAL	Fri Dec 16 20:49:50 2016	(r310176)
> +++ head/sys/amd64/conf/MINIMAL	Fri Dec 16 21:10:37 2016	(r310177)
> @@ -94,6 +94,7 @@ options 	MALLOC_DEBUG_MAXZONES=8	# Separ
>  # Make an SMP-capable kernel by default
>  options 	SMP			# Symmetric MultiProcessor Kernel
>  options 	DEVICE_NUMA		# I/O Device Affinity
> +options 	EARLY_AP_STARTUP
>  
>  # CPU frequency control
>  device		cpufreq
> 
> Modified: head/sys/i386/conf/GENERIC
> ==============================================================================
> --- head/sys/i386/conf/GENERIC	Fri Dec 16 20:49:50 2016	(r310176)
> +++ head/sys/i386/conf/GENERIC	Fri Dec 16 21:10:37 2016	(r310177)
> @@ -96,6 +96,7 @@ options 	MALLOC_DEBUG_MAXZONES=8	# Separ
>  # To make an SMP kernel, the next two lines are needed
>  options 	SMP			# Symmetric MultiProcessor Kernel
>  device		apic			# I/O APIC
> +options 	EARLY_AP_STARTUP
>  
>  # CPU frequency control
>  device		cpufreq
> 
> 
> 

-- 
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid