maintainer-feedback requested: [Bug 253278] x11-servers/xorg-server: Lock file: Various fixes

[bugzilla-noreply at freebsd.org]

Bugzilla Automation <bugzilla at FreeBSD.org> has asked freebsd-x11 (Nobody)
<x11 at FreeBSD.org> for maintainer-feedback:
Bug 253278: x11-servers/xorg-server: Lock file: Various fixes
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253278



--- Description ---
Several fixes:

1. Create a lock file in the case of an explicitly requested display even if
"-displayfd" was specified. This is because, in this case, the server creation
process is essentially the same as when "-displayfd" is not specified. The only
difference with the latter case should be that Xorg outputs the passed display
to the display FD (only the display selection logic is bypassed).

2. Properly indicate an unexpected problem with link(2), instead of assuming
that a failure always means that the file indeed exists.

3. Workaround for what appears to be a FreeBSD bug (link returns EPERM when
hard linking a file whose permissions are the result of creating a file in a
directory with sticky bit, although creating a separate copy is perfectly
possible). Additional benefit: Simplifies the cumbersome logic, which on POSIX
systems is unnecessary IMHO (initial lock file creation with O_EXCL is enough
to ensure mutual exclusion).

Again I'm submitting this here, since upstream seems inactive.