[Bug 250336] lang/clover: link failure after update to 20.2

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250336

--- Comment #5 from John Hein <jcfyecrayz at liamekaens.com> ---
I ran a run in poudriere (11-stable/amd64) with the following patch on every
port that included mesa-dri/Makefile.common, and they all built fine.

==========================
--- graphics/mesa-dri/Makefile.common   (revision 552118)
+++ graphics/mesa-dri/Makefile.common   (working copy)
@@ -61,8 +61,10 @@
 .if ${/usr/bin/ld:L:tA} != /usr/bin/ld.lld
 # --build-id isn't supported by old GNU ld.bfd in base
 # Also ld.bfd have problems that seems related to --as-needed
-USE_BINUTILS=          yes
-LDFLAGS+=              -B${LOCALBASE}/bin
+# Even the ld from the latest binutils port had some troubles (lang/clover -
bug 250336).
+#USE_BINUTILS=         yes
+#LDFLAGS+=             -B${LOCALBASE}/bin
+LDFLAGS+=              -fuse-ld=lld
 .endif

 # only have one port to check with portscout.
==========================


Using that instead of a patch only on lang/clover is probably better (reduces
dependencies on devel/binutils).

Whether the committer keeps the ".if ${/usr/bin/ld:L:tA} != /usr/bin/ld.lld"
(see comment 2, comment 3, comment 4) I leave to your discretion.  I think I
slightly prefer the non-conditional simple case.  A simple comment in the
Makefile - '# remove after 11.x support ends' - is probably worthwhile (along
with a better comment in the commit message).

I don't think any of these possible changes require any PORTREVISION bumps.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.