[Bug 227967] [usability] x11-servers/xorg-server ships with black background which makes debugging X hard

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Wed Mar 25 10:49:55 UTC 2020


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227967

--- Comment #7 from Alexey Dokuchaev <danfe at FreeBSD.org> ---
(In reply to Chris Rees from comment #6)
> Hm, I'm not sure that 'black' is chosen as a 'wallpaper'...
> Unless you've found the code that chooses black?
I guess you're right, it's not that simple.  Basically, the logic goes like
this:

>  if (party_like_its_1989) { // -retro
>      MakeRootTile(pWin);
>      backFlag |= CWBackPixmap;
>  }
>  else {
>      pWin->backgroundState = BackgroundPixel;
>      if (whiteRoot) // -wr
>          pWin->background.pixel = pScreen->whitePixel;
>      else
>          pWin->background.pixel = pScreen->blackPixel;
>      backFlag |= CWBackPixel;
>  }
So it's special "blackPixel" colormap entry, not simply "solid black".  I guess
we're better off properly documenting how users can select 1989-style (-retro)
or solid white (-wr) backgrounds.

Another option would be to look into how OpenBSD patches it, but I don't feel
motivated enough.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-x11 mailing list