[Bug 243649] [patch] devel/libepoll-shim: Update to 0.0.20191117 version to unbreak re-plugging input devices

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Jan 31 17:32:12 UTC 2020


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243649

Michael Gmelin <grembo at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #211221|0                           |1
        is obsolete|                            |

--- Comment #10 from Michael Gmelin <grembo at FreeBSD.org> ---
Created attachment 211223
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=211223&action=edit
Patch to change libepoll-shim to use actual upstream, test targets, update to
20191117, more cosmetic changes

(In reply to Jan Beich from comment #9)

> Sort USES alphabetically. If unsure use ports-mgmt/portfmt then
> check the diff.
That's what I tried :p. TBH, I hoped that portlint would catch that.
Wasn't aware of portfmt, thanks!

>> +
>> +USE_LDCONFIG=	yes
>>  USE_GITHUB=	yes


> Maybe drop newline after USES per bug 231422. However, if you do then a 
> newline before TEST_TARGET is also unnecessary.

Ok, why not :)


> At least running 32-bit Wayland clients on 64-bit compositor works fine. 
> Testing runtime on the oldest supported/alternative architecture
> (like 11.3 i386 atm) is part of my pre-commit menu e.g., for www/firefox.

The first test on i386 fails on purpose, the second one is a sizeof
mismatch of some sort (confirmed on i386 on bhyve) - might very well
be a problem with the unit test itself (it also fails without
a message, which should be fixed upstream - I would leave that
to someone else or at least a different point in time though)

> Some tests seem to fail even on amd64 if run inside poudriere jail.
Which ones though and why/with which error message? I tested about
20 times on 11.3 and 12.1 and had no problems. Two things I noticed:

- The unit tests can't run in parallel (e.g. ctest -j4
  makes some tests fail).
- When testing i386 running on bhyve I've seen a few random failures
  on timing sensitive tests that didn't happen when running natively/inside
  a jail.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-x11 mailing list