maintainer-feedback requested: [Bug 244353] x11-drivers/xf86-video-scfb: Unbreak on xorg-server 1.20.7 (and minor cleanup)

[bugzilla-noreply at freebsd.org]

Bugzilla Automation <bugzilla at FreeBSD.org> has asked freebsd-x11 mailing list
<x11 at FreeBSD.org> for maintainer-feedback:
Bug 244353: x11-drivers/xf86-video-scfb: Unbreak on xorg-server 1.20.7 (and
minor cleanup)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244353



--- Description ---
Besides pulling in the patch from github, this also does some
minor cleanup to pacify portlint.

See https://github.com/rayddteam/xf86-video-scfb/pull/4

When loading scfb on xorg 1.20.7 it fails with an
undefined symbol error:

scfb trace: probe start
scfb trace: probe done
scfb: PreInit 0
scfb: PreInit done
scfb: ScfbScreenInit 0
bitsPerPixel=32, depth=24, defaultVisual=TrueColor
mask: ff0000,ff00,ff, offset: 16,8,0
mmap returns: addr 0x805a10000 len 0x640000, fd 12, off 0
scfb: ScfbSave 0
scfb: ScfbSave done
scfb: ScfbScreenInit done
ld-elf.so.1: /usr/local/lib/xorg/modules/drivers/scfb_drv.so: Undefined
symbol "shadowUpdatePackedWeak"

Disabling ShadowFB makes the driver load, but breaks output.

With this fix, the driver loads and was reported to work
properly (at least for "normal" daily use).

The fix was inspired by a similar change in fbdev:
freedesktop/xf86-video-fbdev at 2673e72

Fix tested on two machines, port build qa with poudriere testport
on amd64 and i386 still running.