[Bug 237642] x11-drivers/xf86-video-ati: Upgrade from 18.1.0 to 19.0.0 results in invisible mouse pointer

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237642

--- Comment #31 from Alexey Dokuchaev <danfe at FreeBSD.org> ---
> I'm also curious if this is a problem only with drm-legacy-kmod,
> or also with drm-kmod.
I've tried building graphics/drm-fbsd11.2-kmod on my 13-CURRENT, which is based
on Linux 4.11 code and thus should suck less than 4.16 one, but that was
wishful thinking.  There were some error messages on the console before the
screen went blank and machine locked up, I'd have to see if this contributes to
the problem.

> I wonder if drmIoctl() in libdrm needs to be rewritten on FreeBSD,
> to return errno or -errno rather than the return value of the actual
> ioctl() call.
No.  drmIoctl() should follow ioctl() semantics and return -1 while passing the
error code in errno.  Introducing DRM_IOCTL() was kind of ugly, but breaking
drmIoctl() would be even worse.

The previous code was correct; when Michel Dänzer decided to bypass existing
API and call drmIoctl() directly, he should have updated the code to check for
error condition properly instead of comparing return value with what would be
in the errno.

-- 
You are receiving this mail because:
You are the assignee for the bug.