[Bug 235886] [patch] x11-clocks/xclock: update to 1.0.8; add missing dependencies and LICENSE

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235886

--- Comment #7 from Samy Mahmoudi <samy.mahmoudi at gmail.com> ---
(In reply to Niclas Zeising from comment #6)

I just had a look at bsd.port.mk and bsd.xorg.mk.

We could stay to:

XORG_CAT=       app
USES=           iconv
USE_XORG=       xrender xft xkbfile xt xaw

or we could go for:

USES=           iconv
XORG_CAT=       app
USE_XORG=       xrender xft xkbfile xt xaw

or even:

XORG_CAT=       app

USES=           iconv
USE_XORG=       xrender xft xkbfile xt xaw

These blocks would have the same effect: XORG_CAT only needs to be before
USE_XORG, as you suggested. But which style do you prefer (in case we submit
patches for portlint and the handbook) ?

IMHO, we should mention XORG_CAT directly before USE_XORG (second alternative)
to avoid duplication of Xorg-related variables, as in:

XORG_CAT=       app
USES=           iconv
USE_SOMETHING=
USE_SOMETHING=
USE_SOMETHING=
USE_SOMETHING=
USE_SOMETHING=
USE_XORG=       xrender xft xkbfile xt xaw

-- 
You are receiving this mail because:
You are the assignee for the bug.