DRM driver build fail

[Jan Beich]

(Assuming master is HEAD aka -CURRENT).

"Johannes Lundberg" <johalun at freebsd.org> writes:

> FreeBSD DRM Drivers Build Results
>
> STABLE-11: Version 1103504. Revision 355731.
> STABLE-12: Version 1201504. Revision 355704.
> HEAD:      Version 1300067. Revision 355732.
>
>
> Failed on Fri Dec 13 15:01:57 MST 2019:
>
> https://people.freebsd.org/~johalun/drmlogs/ERROR-aarch64__master__drm-v5.0.log
> https://people.freebsd.org/~johalun/drmlogs/ERROR-amd64__master__drm-legacy.log
> https://people.freebsd.org/~johalun/drmlogs/ERROR-amd64__master__drm-v4.16.log
> https://people.freebsd.org/~johalun/drmlogs/ERROR-amd64__master__drm-v5.0.log
> https://people.freebsd.org/~johalun/drmlogs/ERROR-i386__master__drm-legacy.log
> https://people.freebsd.org/~johalun/drmlogs/ERROR-i386__master__drm-v4.16.log
> https://people.freebsd.org/~johalun/drmlogs/ERROR-i386__master__drm-v5.0.log
> https://people.freebsd.org/~johalun/drmlogs/ERROR-powerpc64__master__drm-v5.0.log

drivers/gpu/drm/drm_os_freebsd.c:47:3: error: implicit declaration of function 'untimeout' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                untimeout(clear_debug_func, NULL, reset_debug_log_handle);
                ^
drivers/gpu/drm/drm_os_freebsd.c:57:28: error: implicit declaration of function 'timeout' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                reset_debug_log_handle = timeout(clear_debug_func, NULL,
                                         ^
drivers/gpu/drm/drm_os_freebsd.c:57:26: error: assigning to 'struct callout_handle' from incompatible type 'int'
                reset_debug_log_handle = timeout(clear_debug_func, NULL,
                                       ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

drm-v5.0 built fine here just 2 days ago. Regressed by https://reviews.freebsd.org/D22602
Other kms-drm branches appear to be affected by the same issue. D22602 lists fixes
for base drivers in Revision Contents -> Stack which one can use as examples e.g.,
D22598 replaced untimeout() with callout_drain() but... let me run away. ;)