build-able drm-i915-update-38

[Jean-Sébastien Pédron]

On 15/01/2016 11:28, Nikola Pajkovsky wrote:
> BUG_ON() is defined in linux.git/include/asm-generic/bug.h as
> 
>    #ifndef HAVE_ARCH_BUG
>    #define BUG() do { \
>    	printk("BUG: failure at %s:%d/%s()!\n", __FILE__, __LINE__, __func__); \
>    	panic("BUG!"); \
>    } while (0)
>    #endif
> 
>    #ifndef HAVE_ARCH_BUG_ON
>    #define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while(0)
>    #endif
> 
> and HAVE_ARCH_BUG is defined for x86, hence, BUG_ON must be *on* always,
> even in kernel w/o debugging options.

For now in FreeBSD, I defined BUG_ON() to be the same as KASSERT(). I
now see that for BUG(), I defined it as panic(), so it's still effective
on a non-debug kernel. Therefore, both definitions are inconsistents...

In your pull request, feel free to change how BUG() and BUG_ON() are
defined so they are always active and consistent.

-- 
Jean-Sébastien Pédron

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-x11/attachments/20160115/b5c5d5c4/attachment.sig>