maintainer-feedback requested: [Bug 197184] x11/libxkbfile: fix build with clang 3.6.0

[bugzilla-noreply at freebsd.org]

Dmitry Marakasov <amdmi3 at FreeBSD.org> has reassigned Bugzilla Automation
<bugzilla at FreeBSD.org>'s request for maintainer-feedback to x11 at FreeBSD.org:
Bug 197184: x11/libxkbfile: fix build with clang 3.6.0
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197184



--- Description ---
Created attachment 152348
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=152348&action=edit
Patch

I'm testing ports building on experimental projects/clang360-import branch, and
libxkbfile fails there because of more strict warnings of clang 3.6:

---
===>  Building for libxkbfile-1.0.8_2
/usr/bin/make  all-recursive
Making all in src
  CC	 cout.lo
cout.c:48:46: error: address of array 'xkb->names->vmods' will always evaluate
to 'true' [-Werror,-Wpointer-bool-conversion]
    if ((!xkb)||(!xkb->names)||(!xkb->names->vmods))
				~~~~~~~~~~~~~^~~~~
1 error generated.
*** Error code 1
---

The vmods member is really an array, so the warning is valid. The fix is to
remove the useless check. It was already fixed upstream:

http://cgit.freedesktop.org/xorg/lib/libxkbfile/commit/?id=9fa04388dcbb5bf20531
9569f540a62c03754688

--- Comment #1 from Bugzilla Automation <bugzilla at FreeBSD.org> ---
Auto-assigned to maintainer x11 at FreeBSD.org