INSTALLS_ICONS being gnome/gtk-oriented, pulling unneeded(?) deps for Qt-ports

Alexey Dokuchaev danfe at nsu.ru
Wed Apr 1 08:29:21 UTC 2015


On Tue, Mar 31, 2015 at 10:53:34PM +0200, Koop Mast wrote:
> On 31-3-2015 18:26, Alexey Dokuchaev wrote:
> >Currently, portlint(1) suggests to add INSTALLS_ICONS knob if it sees
> >share/icons/hicolor/* files in pkg-plist, which in turn means USE_GNOME+=
> >gtk-update-icon-cache and thus pulls things which are from Gtk+ world,
> >and thus seem not quite natural for e.g. Qt-based (or even completely
> >unattached) ports.
> 
> INSTALL_ICONS is only needed for gtk ports, so Qt ports don't need it. I
> guess the check should be updated to take that into account, but it
> might be complex to do so.

Thanks; nice to know Qt ports do not need it.  Having such vaguely-named
knob certainly adds to confusion.  Can its logic be turned into automatic
detection of share/icons/hicolor/* in plist and calling appropriate icon-
cache update commands?  Telling the framework something that it should be
able to detect itself looks bogus.

./danfe


More information about the freebsd-x11 mailing list