[CFT] i915: add HW context support (for Mesa 9.2+)

[Jean-Sébastien Pédron]

On 08.09.2014 11:01, Konstantin Belousov wrote:
> Please do not add dependency on OFED to the drm2.

Thanks for the review, Konstantin!

I should have commentted the OFED part a bit more in my CFT and on the
wiki. If I played with OFED, it's not just for idr. Using a Linux API
wrapper such as the one available in sys/ofed is very handy to greatly
reduce the diff with Linux original code as well as the time taken to
port new code.

I'm not particularily happy with the dependency to OFED, and in the
current patch, this is mostly to have i915 hardware context ready to
test quickly. I planned to send a separate email to discuss the
possibility to move this Linux wrapper in a central place (ie. out of
OFED) so that it's usable by other drivers without depending on OFED itself.

IMHO, using such a wrapper is very valuable (if not required) if we want
to catch up with Linux in the DRM area.

I'll send that mail to freebsd-arch@ in a few minutes. Do you mind if we
move this discussion there?

> What is the revision which you used for import of i915_gem_context.c ?

I used Linux 3.8 (tag: v3.8).

> There were some very subtle semantical changes in the global gtt
> mappings functions, esp. WRT interaction with lowmem conditions.  I am
> not sure if it is applicable, and it would get me some time to really
> remember the details there.

I don't know if it's related, but so far, I received one report from
danfe@ (-CURRENT/i386) talking about:
  intel_do_flush_locked failed: Input/output error (Xorg.log)

and:
  error: [drm:pid12:i915_hangcheck_elapsed] *ERROR* Hangcheck timer
  elapsed... GPU hung (dmesg)

Though, I don't know if it's related to hardware context. I can't test
the patch myself.

> The i915 reset rework looks fine, I have it imported in my WIP branch,
> but I think it will be merged without troubles.
> 
> Why do you need the changes to struct eb_objects ? If this is due to
> OFED, please do not.

Yes, it's because of OFED: FreeBSD's LIST_HEAD and Linux' LIST_HEAD
conflict.

-- 
Jean-Sébastien Pédron

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-x11/attachments/20140908/80ecfe90/attachment.sig>