pixman malformed conditional '$'

[Tijl Coosemans]

On Mon, 03 Feb 2014 09:22:32 +0100 Koop Mast wrote:
> On 3-2-2014 4:19, jhellenthal at dataix.net wrote:
>> Could someone please get rid of the '$' here ?
>>
>> THanks
>>
>> make: "/export/usr/ports/x11/pixman/Makefile" line 23: Malformed conditional (! ${MACHINE_CPU:Mmmx})
>> make: "/export/usr/ports/x11/pixman/Makefile" line 26: Malformed conditional (! ${MACHINE_CPU:Msse2})
>
> We can't get rid of the '$' here they are needed. Can you tell me on 
> which arch this happens?
> make -V ARCH or uname -a output.

For anything non-x86 if you set CPUTYPE in make.conf, MACHINE_CPU isn't
always defined in bsd.cpu.mk.  That's probably a bug in bsd.cpu.mk.

In this case I think it's best to remove the SIMD option.  The configure
script detects if the compiler supports it and at runtime pixman detects
if the cpu supports it.  There's no need to disable this.
There's also SSSE3 and several mips and arm options that are missing, so
the pixman package already has support for those:

checking whether to use MMX intrinsics... disabled
checking whether to use SSE2 intrinsics... disabled
checking whether to use SSSE3 intrinsics... yes

Index: Makefile
===================================================================
--- Makefile    (revision 342362)
+++ Makefile    (working copy)
@@ -14,18 +14,4 @@ USE_AUTOTOOLS=       libtool
 CONFIGURE_ARGS=        --disable-gtk
 USE_GNOME=     ltverhack:30
 
-OPTIONS_DEFINE=        SIMD
-
-.include <bsd.port.options.mk>
-
-.if ! {PORT_OPTIONS:MSIMD}
-CONFIGURE_ARGS=        --disable-vmx --disable-arm-simd
-. if ! ${MACHINE_CPU:Mmmx}
-CONFIGURE_ARGS+=       --disable-mmx
-. endif
-. if ! ${MACHINE_CPU:Msse2}
-CONFIGURE_ARGS+=       --disable-sse2
-. endif
-.endif
-
 .include <bsd.port.mk>