xorg-server fails to build as non-root

[Baptiste Daroussin]

On Fri, Apr 04, 2014 at 02:33:04PM -0400, Julio Merino wrote:
> Hello,
> 
> The staging phase of xorg-server fails when run as non-root because the
> package installation tries to make the Xorg binary setuid root.
> 
> The patch below fixes it.  I'm not sure if there would be a better and
> preferrable alternative.
> 
> Thoughts?
> 
> Thanks!
> 
> 
> Index: Makefile
> ===================================================================
> --- Makefile	(revision 349914)
> +++ Makefile	(working copy)
> @@ -109,6 +109,11 @@
>  .if ${PORT_OPTIONS:MSUID}
>  CONFIGURE_ARGS+=--enable-install-setuid=yes
>  PLIST_SUB+=	SUID=""
> +
> +# The configure script tries to detect if we can install Xorg as root so that
> +# the binary can be made setuid later.  If we are not root, this obviously
> +# fails at one point or another.
> +NEED_ROOT=	yes
>  .else
>  CONFIGURE_ARGS+=--enable-install-setuid=no
>  PLIST_SUB+=	SUID="@comment "
> _______________________________________________
> freebsd-x11 at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-x11
> To unsubscribe, send any mail to "freebsd-x11-unsubscribe at freebsd.org"

I will come with a better patch not adding NEED_ROOT

NEED_ROOT was a mistake I should not have done ;)

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-x11/attachments/20140404/ff22032c/attachment.sig>