ports/145649: x11/xorg: X server crashes when starting opengl compositing manager

[Andriy Gapon]

The following reply was made to PR ports/145649; it has been noted by GNATS.

From: Andriy Gapon <avg at icyb.net.ua>
To: bug-followup at FreeBSD.org, akirchhoff135014 at comcast.net
Cc: Robert Noland <rnoland at FreeBSD.org>
Subject: Re: ports/145649: x11/xorg: X server crashes when starting opengl
 compositing manager
Date: Sat, 22 May 2010 14:19:35 +0300

 This is a multi-part message in MIME format.
 --------------030209010402000901050207
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: 7bit
 
 
 The attached patch fixes the issue for me.
 I do not understand overall application logic, but in local code context I see
 that intelObj->mt is only accessed when intelObj->imageOverride is false.
 The place where crash happens is the only exception.
 
 So far everything works well and I do not see any side-effects or other issues
 with i915_dri and OpenGL.
 
 The same code seems to be present in 7.6 and 7.7 upstream branches, the code in
 7.8 and master seems to be too different.  Not sure if this issue needs to be
 reported to Mesa folks.
 
 -- 
 Andriy Gapon
 
 --------------030209010402000901050207
 Content-Type: text/plain;
  name="intel-opengl.patch"
 Content-Transfer-Encoding: base64
 Content-Disposition: inline;
  filename="intel-opengl.patch"
 
 LS0tIHNyYy9tZXNhL2RyaXZlcnMvZHJpL2k5MTUvaTkxNV90ZXhzdGF0ZS5jLm9yaWcJMjAx
 MC0wNS0yMiAwMjoxNzoxMS4xNjIzMDIwMjMgKzAzMDAKKysrIHNyYy9tZXNhL2RyaXZlcnMv
 ZHJpL2k5MTUvaTkxNV90ZXhzdGF0ZS5jCTIwMTAtMDUtMjIgMDI6MTg6MTQuMTQ3MDE3MDY0
 ICswMzAwCkBAIC0xOTQsNyArMTk0LDcgQEAKICAgICAgICgoKGZpcnN0SW1hZ2UtPkhlaWdo
 dCAtIDEpIDw8IE1TM19IRUlHSFRfU0hJRlQpIHwKICAgICAgICAoKGZpcnN0SW1hZ2UtPldp
 ZHRoIC0gMSkgPDwgTVMzX1dJRFRIX1NISUZUKSB8IGZvcm1hdCk7CiAKLSAgIGlmIChpbnRl
 bE9iai0+bXQtPnJlZ2lvbi0+dGlsaW5nICE9IEk5MTVfVElMSU5HX05PTkUpIHsKKyAgIGlm
 ICghaW50ZWxPYmotPmltYWdlT3ZlcnJpZGUgJiYgaW50ZWxPYmotPm10LT5yZWdpb24tPnRp
 bGluZyAhPSBJOTE1X1RJTElOR19OT05FKSB7CiAgICAgICBzdGF0ZVtJOTE1X1RFWFJFR19N
 UzNdIHw9IE1TM19USUxFRF9TVVJGQUNFOwogICAgICAgaWYgKGludGVsT2JqLT5tdC0+cmVn
 aW9uLT50aWxpbmcgPT0gSTkxNV9USUxJTkdfWSkKIAkgc3RhdGVbSTkxNV9URVhSRUdfTVMz
 XSB8PSBNUzNfVElMRV9XQUxLOwoK
 --------------030209010402000901050207--