ports/137373: x11/libX11: make dependance on x11/libxcb

[Carlos A. M. dos Santos]

On Sun, Dec 20, 2009 at 12:04 AM, Robert Noland <rnoland at freebsd.org> wrote:
> On Sat, 2009-12-19 at 22:20 +0000, Carlos A. M. dos Santos wrote:
...
>>  Robert,
>>
>>  I think I foud what "mesa" you are talking about: graphics/libGL. Well
>>  if you pay attention to the contents of bsd.mesalib.mk then you will
>>  see that it already recognizes a WITHOUT_XCB knob. That knob is there
>>  since the update X.org ports to 7.4+, last january. But I don't need
>>  to tell this to you. have been updating that file for ten  months, so
>>  you know its contents.
>>
>>  So, in the very end, you are attempting to convince me that that
>>  giving the user the opportunity to turn off XCB is accetpable in
>>  libGL, but not in libX11. This is contradictory.
>>
>>  By the way, the assertion that "having a non-xcb enabled libx11 would
>>  cause weird build/run time issues" is  false.
>
> If it is disabled everywhere, it is fine.  But having it disabled for
> libx11 and enabled for xserver and/or mesa (libGL and friends) would be
> problematic.
>
> robert.

Is it acceptable a patch allowing to diable XCB without a menu? The
default behavior is kept but users can put "WITHOUT_XCB=true" in
/etc/make.conf, ensuring that all ports are built the same way.