[PATCH] Invisible search button text

Giorgos Keramidas keramida at freebsd.org
Wed May 17 00:09:52 UTC 2006


On 2006-05-12 16:49, Fabian Keil <freebsd-listen at fabiankeil.de> wrote:
> As reported back in January, the design with the new logo
> brakes even more things than the older one, if the user
> commited the crime to change his font settings to his
> preferences.
>
> The search button has invisible text because the button's
> background is transparent, its text is white and the background
> behind the button is white too.
>
> Please have a look at the screen shot Niek Dekker posted today on
> freebsd-doc@: http://www.nlnet.org/freebsd.org.jpg
> or the one I posted a while back:
> http://www.fabiankeil.de/tmp/freebsd.org-new-logo-in-firefox-1024x768.png
>
> This patch:
> --- /tmp/privoxy-filter-test/global.css.orig	Fri May 12 16:43:33 2006
> +++ /tmp/privoxy-filter-test/global.css	Fri May 12 16:43:33 2006
> @@ -91,7 +91,7 @@
>
>  #SEARCH form #SUBMIT, #search form #submit {
>    font-size: 0.8em;
> -  background: transparent;
> +  background-image: url(../images/hdr_fill.png);
>    color: #fff;
>    border-right: 1px solid #DADADA;
>    border-bottom: 1px solid #DADADA;
>
> makes the button visible again.

Without any intention to put down your most appreciated will to
help with the look of the site, the patch is just a "hack" that
does not solve the *real* problem: that the current CSS-based
layout is broken and requires a specific font size to work.

I'm not fond of the current state of the front page and a few
other deeper-level pages, but the fix of the real problems is
going to be more difficult that just changing a color here and
there, IMHO :(

> If the user accidently uses the font-size the designer
> expected, the background color no longer matches exactly,
> but I think it's close enough.

Exactly.  Which is the reason I don't really like hacking around
colors to fix the layout problems :-/



More information about the freebsd-www mailing list