query-pr-summary.cgi rework

Giorgos Keramidas keramida at freebsd.org
Thu Sep 1 20:07:33 GMT 2005


On 2005-09-01 19:41, Daniel Gerzo <danger at rulez.sk> wrote:
> Hello www,
>
>   I would like to announce my work to you and get some feedback. If
>   you feel that the patch is okay and doesn't need any more changes,
>   I would like to send PR and get it commited :-)
>
>   Changes to the query-pr-summary.cgi script include:
>
>   o) rewritten code so it's more readable now, replaced some " with '.
>   o) make the html output html valid.
>   o) the minor feature I've added is that the PRs in the html output
>      are now splitted according to the each PR's state and each state
>      has it's own color, so it's easier now to determinate the PR's
>      state on the web page. This has been done by adding a few css
>      classes, so if colors aren't meeting our needs, it is pretty
>      easy to modify them.
>
>   This work was already tested by remko@ and it seems to work. The
>   affects of my work are visible at for example:
>
>   http://people.freebsd.org/~remko/danger-test/query-pr-summary2.cgi?category=conf

This looks nice.  I like the use of the existing stylesheet for
coloring.  If Remko wants to commit it, there's no objection from me.



More information about the freebsd-www mailing list