[Bug 193588] [new port] net/malo-firmware-1.4: Staged malo(4) firmware module

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193588

Bartek Rutkowski <robak at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch Ready                 |In Discussion

--- Comment #22 from Bartek Rutkowski <robak at freebsd.org> ---
John, I've few doubts about the package, namely the issues listed by portlint:

WARN: Makefile: use of DISTFILES with single file discouraged. distribution
filename should be set by DISTNAME and EXTRACT_SUFX.
WARN: Makefile: Consider defining LICENSE.
WARN: Makefile: DISTFILES/DISTNAME affects WRKSRC. take caution when changing
them.
WARN: Makefile: "NO_PACKAGE" found. do not forget to update ports/LEGAL.

and the fact that the port is called 'malo-firmware-1.4' however, the port
version seems to be extracted from firmware version, that comes from distfiles
and currently is  '3.0.0.39', so the package name will be extremely confusing,
like 'malo-firmware-1.4-3.0.0.39'. Beside that, what's the '1.4', if the port
version is '3.0.0.39'?

Mind looking into the Makefile a bit more carefully and help us solve the
puzzle?

-- 
You are receiving this mail because:
You are on the CC list for the bug.