Fine, OK, here's my initial AR9380/AR9485 support

[Joshua Isom]

On 3/12/2013 4:14 PM, Adrian Chadd wrote:
> On 12 March 2013 14:12, Joshua Isom <jrisom at gmail.com> wrote:
>> I had to remove the /sys/ from the PATH and CFLAGS to point to the right
>> directory, it's still failing with warnings.  I tried gcc and clang. I'll
>> try to see how much I can patch myself without knowing the code at all.
>
> Hi,
>
> Where's it failing with warnings with gcc?
>
> I do gcc builds all the time and I get no warnings. But my primary
> station/laptop testing atm is on 9-STABLE (my access points run -HEAD
> atm.)
>
> Thanks,
>
>
> Adrian
>

This I think is because I'm building on amd64, so it should be 64 bit 
type for portability.

> /root/ATH/head/sys/modules/ath/../../contrib/dev/ath/ath_hal/ar9300/ar9300_gpio.c: In function 'ar9340_soc_gpio_cfg_output_mux':
> /root/ATH/head/sys/modules/ath/../../contrib/dev/ath/ath_hal/ar9300/ar9300_gpio.c:63: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

This is because of a debug def not being set I think, and the 
preprocessor optimizes away the actual use.

> /root/ATH/head/sys/modules/ath/../../contrib/dev/ath/ath_hal/ar9300/ar9300_radio.c: In function 'ar9300_set_channel':
> /root/ATH/head/sys/modules/ath/../../contrib/dev/ath/ath_hal/ar9300/ar9300_radio.c:83: warning: unused variable 'ichan' [-Wunused-variable]

The first warning looks like it's because of an "#if 0" that blocks it 
from being set.  The second looks genuine, it's only guaranteed to be 
set inside of one conditional.

> /root/ATH/head/sys/modules/ath/../../contrib/dev/ath/ath_hal/ar9300/ar9300_reset.c: In function 'ar9300_reset':
> /root/ATH/head/sys/modules/ath/../../contrib/dev/ath/ath_hal/ar9300/ar9300_reset.c:2809: warning: 'modes_txgaintable_index' is used uninitialized in this function
> /root/ATH/head/sys/modules/ath/../../contrib/dev/ath/ath_hal/ar9300/ar9300_reset.c:2609: note: 'modes_txgaintable_index' was declared here
> /root/ATH/head/sys/modules/ath/../../contrib/dev/ath/ath_hal/ar9300/ar9300_reset.c:3252: warning: 'cal_done' may be used uninitialized in this function
> /root/ATH/head/sys/modules/ath/../../contrib/dev/ath/ath_hal/ar9300/ar9300_reset.c:3252: note: 'cal_done' was declared here