[IWN] Reviw split 2

[Cedric GROSS]

> De : adrian.chadd at gmail.com [mailto:adrian.chadd at gmail.com] De la part
> de Adrian Chadd
> Envoyé : samedi 3 août 2013 20:20
> À : Cedric GROSS
> Cc : freebsd-wireless at freebsd.org
> Objet : Re: [IWN] Reviw split 2
> 
> On 3 August 2013 04:23, Cedric GROSS <cg at cgross.info> wrote:
> 
> >> Can you please post an updated diff against what's in -HEAD now?
> >
> > As requested here is full patch.
> 
> Thanks!
> 
> > It should. 4965 part was not impacted. But Don't you said that full
> > patch break your 5100 ?
> 
> Yup, it is breaking it very quickly. I'll try this patch against -HEAD
> and see what happens.

Ok.

> 
> But, there's ~ 4000 lines of patch to review. Some bits are easy to
> merge, some bits aren't easy to merge. :)
> 

It's surely in parameters part that there's a fail. May be will end by that.

> Thanks! What would you like to merge next?

Prepare for context switching (the sc->rxon modification), it's still
modification without adding functionality. 

And after that, adding context switching with PAN support, should not break
your NIC.
Next, may be parameter by parameter, so we will see where is break.

With bapt help, I'm also pointing a problem with AMRR. With time, rate is
still decreasing because of cumulative ackfailcnt transmit to
ieee80211_ratectl_tx_complete.

What kind of value does this function wait ? Absolute number or relative to
the previous call ?
Also, why do you send it by ref in iwn_tx_done ?

> 
> -adrian
Cedric