[iwn] Review split 3

Adrian Chadd adrian at freebsd.org
Fri Aug 2 21:23:42 UTC 2013


Committed ,thanks!



-adrian

On 29 July 2013 11:39, Cedric GROSS <cg at cgross.info> wrote:
>
>
>> De : Warren Block [mailto:wblock at wonkity.com]
>> Envoyé : lundi 29 juillet 2013 20:11
>> À : Adrian Chadd
>> Cc : Cedric GROSS; freebsd-wireless at freebsd.org
>>
>> On Mon, 29 Jul 2013, Adrian Chadd wrote:
>>
>> > Hi!
>> >
>> > Cool! ok, the style niggles.
>> >
>> > * Your #define IWN_blah needs a TAB between #define and the IWN_blah
>> > value. Right now you have spaces.
>
> Ok, I tough you need spaces between #define and values...
>
> standard single-include stuff : Done
> $FreeBSD$ : Moved
>
> Each file is different. Really hard to find something common. Man 9 style is
> quite useful but enough precise for tab and space usage I think.
>
>>
>> There is whitespace at the end of some of the comment lines also.
>>
>> textproc/igor will find problems like that:
>>
>>    igor -R filename | less -RS
>
> Thanks for that Warren !


More information about the freebsd-wireless mailing list